Fix RAC collections in React canary versions #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
reidbarber
approved these changes
May 12, 2023
snowystinger
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4390
This runs our tests against the new React Canary versions in CI. Next.js is using the canary version in their latest version, and this is now an officially supported setup by the React team.
As reported in #4390, the React Aria Components collection implementation was broken in the canary versions of React because our hack of using the
multipleprop to pass through an object to the underlying fake DOM node no longer works. This is fixed by using a callback ref to imperatively set the props ourselves. This seems cleaner anyway and also fixes the issue in Next.js.